yanbinyang commented on PR #663: URL: https://github.com/apache/flink-agents/pull/663#issuecomment-4447722693
> Thanks for your contribution @yanbinyang. Overall looks good to me, and I left serveral minor comments. > > I think we should also verify Milvus in the test case `Mem0LongTermMemoryTest`. This test is currently disabled due to a bug in Flink itself, which is expected to be fixed in the coming weeks. There are also workarounds available for local execution. You can add the test path for Milvus, and I will verify it locally. Thanks for the suggestion. Addressed in fa34054 by adding a Milvus path to `Mem0LongTermMemoryTest`: the test now parameterizes the Mem0 vector store over Elasticsearch and Milvus, and `Mem0LongTermMemoryAgent` declares a `milvusLtmStore` resource. I couldn't run this e2e test locally because it still depends on the existing Pemja/Flink issue workaround and a local Milvus/Mem0 environment. Could you please help verify the Milvus path locally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
