Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3128#discussion_r97319035
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -50,12 +51,27 @@
private MetricDumpSerialization() {
}
+ public static class MetricSerializationResult {
--- End diff --
This is not `Serializable` and would fail when send with Akka. The
following test fails:
```java
@Test
public void testJavaSerialization() throws IOException {
MetricDumpSerialization.MetricDumpSerializer serializer = new
MetricDumpSerialization.MetricDumpSerializer();
final ByteArrayOutputStream bos = new ByteArrayOutputStream(1024);
final ObjectOutputStream oos = new ObjectOutputStream(bos);
oos.writeObject(serializer.serialize(
new HashMap<Counter, Tuple2<QueryScopeInfo,String>>(),
new HashMap<Gauge<?>, Tuple2<QueryScopeInfo,String>>(),
new HashMap<Histogram, Tuple2<QueryScopeInfo,String>>(),
new HashMap<Meter, Tuple2<QueryScopeInfo,String>>()));
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
