ferenc-csaky commented on code in PR #244:
URL:
https://github.com/apache/flink-connector-aws/pull/244#discussion_r3241602220
##########
flink-connector-aws-e2e-tests/flink-formats-json-glue-schema-registry-e2e-tests/src/test/java/org/apache/flink/glue/schema/registry/test/json/GlueSchemaRegistryJsonKinesisITCase.java:
##########
@@ -92,21 +93,21 @@ public class GlueSchemaRegistryJsonKinesisITCase extends
TestLogger {
private KinesisClient kinesisClient;
private GSRKinesisPubsubClient gsrKinesisPubsubClient;
- @ClassRule
+ @Container
public static LocalstackContainer mockKinesisContainer =
new
LocalstackContainer(DockerImageName.parse(LOCALSTACK_DOCKER_IMAGE_VERSION))
.withNetworkAliases("localstack");
- @Before
+ @BeforeEach
public void setup() throws Exception {
System.setProperty(SdkSystemSetting.CBOR_ENABLED.property(), "false");
- Assume.assumeTrue(
- "Access key not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(ACCESS_KEY));
- Assume.assumeTrue(
- "Secret key not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(SECRET_KEY));
+ Assumptions.assumeTrue(
+ !StringUtils.isNullOrWhitespaceOnly(ACCESS_KEY),
+ "Access key not configured, skipping test...");
+ Assumptions.assumeTrue(
+ !StringUtils.isNullOrWhitespaceOnly(SECRET_KEY),
+ "Secret key not configured, skipping test...");
Review Comment:
Let's use AssertJ's `Assumptions.assumeThat`. I'd prefer static import that
method too, but that's maybe personal taste.
Same applies to `GlueSchemaRegistryAvroKinesisITCase`.
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/table/KinesisDynamicTableSourceFactoryTest.java:
##########
@@ -60,7 +59,7 @@
import static org.assertj.core.api.Assertions.assertThat;
/** Test for {@link KinesisDynamicSource} created by {@link
KinesisDynamicTableFactory}. */
-public class KinesisDynamicTableSourceFactoryTest extends TestLogger {
+public class KinesisDynamicTableSourceFactoryTest {
Review Comment:
To keep the `TestLogger` on JUnit5 there is a matching extension:
```java
@ExtendWith(TestLoggerExtension.class)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
