jlalwani-amazon commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3243009309
##########
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java:
##########
@@ -295,8 +295,8 @@ public void testCreateTable() throws Exception {
}
@Test
- public void testCreateTableWithConstraints() throws Exception {
- Assume.assumeTrue(HiveVersionTestUtil.HIVE_310_OR_LATER);
+ void testCreateTableWithConstraints() throws Exception {
+ Assumptions.assumeTrue(HiveVersionTestUtil.HIVE_310_OR_LATER);
Review Comment:
Should we use static imports everywhere? or only for Assumptions and
Assertions. `HiveTestUtils` has static methods that are not being imported
staticly. I'm not changing those static imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
