raminqaf commented on code in PR #28189:
URL: https://github.com/apache/flink/pull/28189#discussion_r3258221409
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/RegexpExtractInputTypeStrategyTest.java:
##########
@@ -55,6 +55,6 @@ protected Stream<TestSpec> testData() {
TestSpec.forStrategy("Invalid literal regex fails at plan
time", REGEXP_EXTRACT)
.calledWithArgumentTypes(DataTypes.STRING(),
DataTypes.STRING())
.calledWithLiteralAt(1, "(")
- .expectErrorMessage("Invalid regular expression for
REGEXP_EXTRACT:"));
Review Comment:
I am using `callContext.getName()` and in the `InputTypeStrategiesTestBase`
the name of the function is set to `f` (return value of
`callContext.getName()`) that is why I have removed it here.
We can pass the function name through the caller, but I kinda like the API
like this.
However, in the IT cases you can see the full error message with the correct
function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
