[ 
https://issues.apache.org/jira/browse/FLINK-38192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081926#comment-18081926
 ] 

Arvind Kandpal commented on FLINK-38192:
----------------------------------------

Hi [~cailiuyang], I have prepare the patch for this , Please review it whenever 
you have time. 

 

> Improve DynamicSourceUtils exception msg
> ----------------------------------------
>
>                 Key: FLINK-38192
>                 URL: https://issues.apache.org/jira/browse/FLINK-38192
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>            Reporter: Cai Liuyang
>            Priority: Not a Priority
>              Labels: pull-request-available
>
> If DynamicTableSource doesn't impl the interface of SupportsReadingMetadata, 
> it will throw an exception with msg like: "Table 'xxx' declares metadata 
> columns, but the underlying DynamicTableSource doesn't implement the 
> SupportsReadingMetadata interface. Therefore, metadata cannot be read from 
> the given source. ",see 
> code:[DynamicSourceUtils#validateAndApplyMetadata|https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java#L442]
>  
> maybe we can print DynamicTableSource's real class name rather than 
> DynamicTableSource to provide more information



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to