Samrat002 commented on code in PR #28190: URL: https://github.com/apache/flink/pull/28190#discussion_r3265051546
########## flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/token/DynamicTemporaryAWSCredentialsProvider.java: ########## @@ -27,7 +27,10 @@ import software.amazon.awssdk.auth.credentials.AwsSessionCredentials; import software.amazon.awssdk.services.sts.model.Credentials; +import javax.annotation.concurrent.ThreadSafe; + @Internal +@ThreadSafe Review Comment: @gaborgsomogyi : if we say thread safe , from what thread we are protecting against ? if not then we dont care . If there are multiple thread involved. list them ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
