Savonitar commented on code in PR #254:
URL:
https://github.com/apache/flink-connector-kafka/pull/254#discussion_r3265734925
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -174,9 +175,14 @@ public static void teardownAdmin() {
}
@BeforeEach
- void setUp() throws ExecutionException, InterruptedException {
+ void setUp() {
topic = UUID.randomUUID().toString();
- createTestTopic(topic, 1, TOPIC_REPLICATION_FACTOR);
+ Properties adminProperties = new Properties();
Review Comment:
getKafkaClientConfiguration() returns consumer properties (+zookeeper
properties, which will be tackled in
https://issues.apache.org/jira/browse/FLINK-39705).
Meanwhile here, we need only admin/generic properties.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
