Au-Miner commented on code in PR #28144:
URL: https://github.com/apache/flink/pull/28144#discussion_r3266541224
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/DataTypeExtractor.java:
##########
@@ -544,6 +550,15 @@ else if (clazz == java.time.Period.class) {
return ClassDataTypeConverter.extractDataType(clazz).orElse(null);
}
+ /** Maps an {@link Enum} class to STRING bridged to the enum class. */
+ private @Nullable DataType extractEnumType(Type type) {
+ final Class<?> clazz = toClass(type);
+ if (clazz == null || !clazz.isEnum()) {
+ return null;
+ }
+ return DataTypes.STRING().bridgedTo(clazz);
Review Comment:
There are annotations in
[notes](https://github.com/apache/flink/pull/28144/changes#diff-7c1b17f4ff0ededfc43d477dd06738f3a96e62952a3eb28a1dde7da63966e023R29)
to explain the current naming convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
