gaborgsomogyi commented on PR #28200:
URL: https://github.com/apache/flink/pull/28200#issuecomment-4496024150

   **Issue 1 — MinIO section: auto-detection claim is incorrect** (~line 263)
   
   Current text:
   ```
   MinIO-specific optimizations are applied automatically:
   - Path-style access enabled
   - Chunked encoding disabled (compatibility)
   - Checksum validation disabled (compatibility)
   ```
   
   `s3.chunked-encoding.enabled` and `s3.checksum-validation.enabled` are plain 
`ConfigOption`s with `defaultValue(true)` 
(`NativeS3FileSystemFactory.java:101–115`). There is no code that auto-disables 
them when a custom endpoint is set — only path-style access is auto-enabled 
(`S3ClientProvider.java:481`). A user copying the MinIO example as-is will have 
both still on, which can cause request failures against MinIO.
   
   Suggested replacement:
   ```
   When a custom endpoint is configured, path-style access is enabled 
automatically.
   Chunked encoding and checksum validation must be disabled manually for MinIO 
compatibility:
   
   ```yaml
   s3.chunked-encoding.enabled: false
   s3.checksum-validation.enabled: false
   ```
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to