PavelZeger opened a new pull request, #1115:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1115
## What is the purpose of the change
This pull request fixes a typo in the `AggregatedMetric#toString()`
implementation where the `min` field name was incorrectly
rendered as `mim`. The fix is applied consistently across all three copies
of `AggregatedMetric` (in `flink-autoscaler`,
`flink-autoscaler-standalone`, and `flink-kubernetes-operator`) and is
covered by new unit tests.
## Brief change log
- Corrected the field label from `mim=` to `min=` in
`AggregatedMetric#toString()`
- Synchronized the three copies of `AggregatedMetric` so they remain
identical
- Added `AggregatedMetricTest` in `flink-autoscaler` and
`flink-autoscaler-standalone` asserting that `toString()` contains the
correct `min=` label
## Verifying this change
This change added tests and can be verified as follows:
- Added `AggregatedMetricTest#testToStringContainsMinFieldName` in
`flink-autoscaler` and `flink-autoscaler-standalone` that
constructs an `AggregatedMetric` and asserts the rendered string contains
`min=`
- `mvn clean verify` passes locally
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changes to the
`CustomResourceDescriptors`: (no)
- Core observer or reconciler logic that is regularly executed: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
