Dennis-Mircea commented on PR #28172: URL: https://github.com/apache/flink/pull/28172#issuecomment-4508620368
> This is a change to the API - can see this in the java docs https://nightlies.apache.org/flink/flink-docs-stable/api/java/overview-tree.html I suggest you deprecate the existing one and introduce the newly correctly named one. Then there will be no migration impact. Thanks for taking a look! I don't think this operator is part of the public API surface, though: - It lives in `flink-table-runtime`, an implementation module. The public API surfaces in Flink are `flink-core-api`, `flink-datastream-api`, and `flink-table-api-java`. - It carries no `@Public` / `@PublicEvolving` / `@Experimental` annotation. The sibling classes in the same package (`PeriodicWatermarkAssignerWrapper`, `PunctuatedWatermarkAssignerWrapper`) are explicitly `@Internal`. - It is only ever instantiated by the planner (`StreamExecMiniBatchAssigner`), and users don't construct it directly. - The Flink Javadoc tree lists every `public`-visibility class, including `@Internal` ones, so presence there isn't evidence of API status. Given that, a typo fix via rename should be safe and keeping a deprecated misspelled shim would just be carrying a misleading class name forward. Please let me know if I'm missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
