davidradl commented on code in PR #28054:
URL: https://github.com/apache/flink/pull/28054#discussion_r3287831354
##########
docs/content/docs/concepts/sql-table-concepts/overview.md:
##########
@@ -278,20 +278,24 @@ Flink SQL> COMPILE PLAN 'file:///path/to/plan.json' FOR
INSERT INTO enriched_ord
- SQL Syntax
```sql
- COMPILE PLAN [IF NOT EXISTS] <plan_file_path> FOR
<insert_statement>|<statement_set>;
-
+ -- Write the compiled plan to a file:
+ COMPILE PLAN '<plan_file_path>' [IF NOT EXISTS] FOR
<insert_statement>|<statement_set>;
+
+ -- Or return the compiled plan inline as a single-row, single-column
STRING result set:
+ COMPILE PLAN FOR <insert_statement>|<statement_set>;
Review Comment:
It looks strange to have COMPILE PLAN to mean write or read depending on the
subsequent syntax. I am not sure about the SQL precedent for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]