rkhachatryan opened a new pull request, #28242:
URL: https://github.com/apache/flink/pull/28242
## What is the purpose of the change
In `LinkedMultiSetState`, `highestSqnAndSizeState` tracks the highest SQN.
It
grows monotinically and is used when linking rows in a double-linked list.
To preserve monotonicity, it should only be incremented on new rows.
However, it is currently updated (to a lower value) when a row is replaced,
breaking the invariant. Linking of the next row added will be broken.
## Brief change log
```
[FLINK-39740][table/runtime] Fix highSqn update in LinkedMultiSetState.add
[hotfix][table/runtime] Remove redundant state access in
LinkedMultiSetState.add
[hotfix][table/runtime] Fix
RowDataKeySerializerSnapshot.resolveSchemaCompatibility()
```
## Verifying this change
Added
- `SequencedMultiSetStateTest.testAddAfterReplacingNonTail` for the main
bugfix
-
`RowDataKeySerializerTest.testResolveSchemaCompatibilityWithDifferentSchema`
for RowDataKeySerializerSnapshot fix
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
