Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3200#discussion_r97593753
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBackendStateMetaInfo.java
---
@@ -92,10 +94,9 @@ public boolean
isCompatibleWith(RegisteredBackendStateMetaInfo<?, ?> other) {
return false;
}
- return ((namespaceSerializer == null &&
other.namespaceSerializer == null)
- || namespaceSerializer == null ||
other.namespaceSerializer == null
- ||
namespaceSerializer.isCompatibleWith(other.namespaceSerializer))
- &&
stateSerializer.isCompatibleWith(other.stateSerializer);
+ return
(stateSerializer.isCompatibleWith(other.stateSerializer)) &&
+
(namespaceSerializer.isCompatibleWith(other.namespaceSerializer)
+ || other.namespaceSerializer
instanceof MigrationNamespaceSerializerProxy);
--- End diff --
I would add a short comment that it's important to check for the
`MigrationNamespaceSerializerProxy`. It could even warrant a test. I can see
how someone removes this line in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
