MartijnVisser opened a new pull request, #28311:
URL: https://github.com/apache/flink/pull/28311
## What is the purpose of the change
The JUnit5 migration (FLINK-39124, #27667) replaced a cause-chain search in
`SavepointITCase.testStopWithSavepointFailsOverToSavepoint`
(`ExceptionUtils.assertThrowable` -> `findThrowable`) with a direct-cause
assertion
(`assertThatThrownBy(...).hasCauseInstanceOf(StopWithSavepointStoppingException.class)`).
Under the AdaptiveScheduler, `StopWithSavepoint.onLeave()` wraps the
expected `StopWithSavepointStoppingException` inside a `FlinkException` ("Stop
with savepoint operation could not be completed."), so it is no longer the
*direct* cause. The default scheduler still exposes it directly, so the test
passes there but fails under the adaptive scheduler. As a result it has failed
every nightly `test_cron_adaptive_scheduler` build on `master` since 2026-03-21
(the first nightly after #27667 merged). The same test still passes under the
adaptive profile on `release-2.0`/`release-2.1`, which retain the pre-migration
assertion. The runtime class `StopWithSavepoint.java` is unchanged between
those branches and `master`; only the test assertion regressed.
This restores the cause-chain search so the test passes under both
schedulers.
## Brief change log
- Replace the direct-cause assertion in
`testStopWithSavepointFailsOverToSavepoint` with
`FlinkAssertions.anyCauseMatches(StopWithSavepointStoppingException.class, "A
savepoint has been created at: ")`, which searches the whole cause chain
(restoring the pre-migration semantics).
## Verifying this change
This change is already covered by the existing
`SavepointITCase.testStopWithSavepointFailsOverToSavepoint`. It was verified
locally:
- Under the default scheduler: `Tests run: 1, Failures: 0, Errors: 0`.
- Under `-Penable-adaptive-scheduler`: `Tests run: 1, Failures: 0, Errors:
0` (red before this change, green after).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no (test-only change)
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (Claude Code (Claude Opus 4.8))
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
