Savonitar commented on PR #262: URL: https://github.com/apache/flink-connector-kafka/pull/262#issuecomment-4624486561
Hi @MartijnVisser . Thank you for the review and merge. > Will you also backport this one to the other branches? Happy to. However, one thing worth flagging from looking at the release-branch weekly CI: this particular readiness race hasn't actually surfaced on v4.0/v3.4, probably because they still run the older ZooKeeper-based testcontainer and show none of the `UnknownTopicOrPartition` failures we see on main's KRaft setup. Backporting the current fix will require more review-efforts (because some methods/classes do not exist in v4.0/3.4) meanwhile currently there is no 100% proof on CI that same issues appear there. However, I analyzed recent CI failures on v4.0 and going to raise: 1 backport of another improvement and fix another potential issue on main branch + backport it to 4.0(unrelated to KRaft and this ticket). Let me know if you think it makes sense anyway to backport KRaft-based fixes with relevant code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
