MartijnVisser commented on code in PR #28312:
URL: https://github.com/apache/flink/pull/28312#discussion_r3362871493


##########
flink-tests/src/test/java/org/apache/flink/test/runtime/IPv6HostnamesITCase.java:
##########
@@ -173,7 +189,8 @@ private Inet6Address getLocalIPv6Address() {
             }
 
             return null;
-        } catch (Exception e) {
+        } catch (Exception | LinkageError e) {
+            LOG.debug("No bindable non-loopback IPv6 address available", e);
             return null;

Review Comment:
   Good point, reverted to `catch (Exception e)` in 8ece9544f8e. The 
`LinkageError` was speculative (never actually observed) and, as you say, would 
turn a genuine class-loading failure into a silent skip — if `RpcSystem.load()` 
ever throws one it should surface, not be swallowed. Kept the `LOG.debug` so a 
skip stays explainable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to