tisyabhatia commented on code in PR #28330:
URL: https://github.com/apache/flink/pull/28330#discussion_r3364940981
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -132,6 +132,12 @@ void testArrayAgg() {
+ "GROUP BY `GENDER`");
}
+ @Test
+ void testGroupByAll() {
+ sql("select\n a, count(*) from t group by all")
+ .ok("SELECT" + " `A`, COUNT(*)\n" + "FROM `T`\n" + "GROUP BY
(ALL)");
Review Comment:
Good catch, thanks - updated my test to match the concatenated style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
