jubins commented on code in PR #28226:
URL: https://github.com/apache/flink/pull/28226#discussion_r3365599324
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/application/ApplicationExceptionsMessageParameters.java:
##########
@@ -30,7 +30,7 @@
/** {@link MessageParameters} for {@link ApplicationExceptionsHandler}. */
public class ApplicationExceptionsMessageParameters extends
ApplicationMessageParameters {
- private final UpperLimitExceptionParameter upperLimitExceptionParameter =
+ public final UpperLimitExceptionParameter upperLimitExceptionParameter =
Review Comment:
good point, since the handler accesses it via
`request.getQueryParameter(UpperLimitExceptionParameter.class)` rather than
directly, there's no need for it to be public. Changed it back to private to
match `JobExceptionsMessageParameters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
