[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837379#comment-15837379 ]
ASF GitHub Bot commented on FLINK-2168: --------------------------------------- Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97730063 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.addons.hbase; + +import org.apache.flink.api.common.typeinfo.BasicArrayTypeInfo; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.util.Preconditions; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.Pair; + +import java.io.Serializable; +import java.math.BigDecimal; +import java.math.BigInteger; +import java.util.List; +import java.util.Map; +import java.util.HashMap; +import java.util.ArrayList; +import java.util.Date; + +/** + * Helps to specify an HBase Table's schema + */ +public class HBaseTableSchema implements Serializable { + + // A Map with key as column family. + private final Map<String, List<Pair>> familyMap = + new HashMap<String, List<Pair>>(); + + // Allowed types. This may change. + // TODO : Check if the Date type should be the one in java.util or the one in java.sql + private static Class[] CLASS_TYPES = { + Integer.class, Short.class, Float.class, Long.class, String.class, Byte.class, Boolean.class, Double.class, BigInteger.class, BigDecimal.class, Date.class + }; + private static byte[] EMPTY_BYTE_ARRAY = new byte[0]; + public void addColumns(String family, String qualifier, TypeInformation<?> type) { + Preconditions.checkNotNull(family, "family name"); + Preconditions.checkNotNull(family, "qualifier name"); + Preconditions.checkNotNull(type, "type name"); + List<Pair> list = this.familyMap.get(family); + if (list == null) { + list = new ArrayList<Pair>(); + } + boolean found = false; + for(Class classType : CLASS_TYPES) { + if(classType == type.getTypeClass()) { + found = true; + break; + } + } + if(!found) { + // by default it will be byte[] type only + type = BasicArrayTypeInfo.BYTE_ARRAY_TYPE_INFO; + } + list.add(new Pair(qualifier, type)); + familyMap.put(family, list); + } + + public Map<String, List<Pair>> getFamilyMap() { + return this.familyMap; + } + + public Object deserialize(byte[] value, TypeInformation<?> typeInfo) { + if (typeInfo.isBasicType()) { + if (typeInfo.getTypeClass() == Integer.class) { + return Bytes.toInt(value); + } else if (typeInfo.getTypeClass() == Short.class) { + return Bytes.toShort(value); + } else if (typeInfo.getTypeClass() == Float.class) { + return Bytes.toFloat(value); + } else if (typeInfo.getTypeClass() == Long.class) { + return Bytes.toLong(value); + } else if (typeInfo.getTypeClass() == String.class) { + return Bytes.toString(value); + } else if (typeInfo.getTypeClass() == Byte.class) { + return value[0]; + } else if (typeInfo.getTypeClass() == Boolean.class) { + return Bytes.toBoolean(value); + } else if (typeInfo.getTypeClass() == Double.class) { + return Bytes.toDouble(value); + } else if (typeInfo.getTypeClass() == BigInteger.class) { + return new BigInteger(value); + } else if (typeInfo.getTypeClass() == BigDecimal.class) { + return Bytes.toBigDecimal(value); + } else if (typeInfo.getTypeClass() == Date.class) { + return new Date(Bytes.toLong(value)); + } + } + return value; + } + + public Object deserializeNull(TypeInformation<?> typeInfo) { + // TODO : this may need better handling. + if(typeInfo.getTypeClass() == Integer.class) { --- End diff -- Why don't try use here ``org.apache.flink.table.codegen.CodeGenUtils#primitiveDefaultValue`` for basic types and ? > Add HBaseTableSource > -------------------- > > Key: FLINK-2168 > URL: https://issues.apache.org/jira/browse/FLINK-2168 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Affects Versions: 0.9 > Reporter: Fabian Hueske > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Labels: starter > > Add a {{HBaseTableSource}} to read data from a HBase table. The > {{HBaseTableSource}} should implement the {{ProjectableTableSource}} > (FLINK-3848) and {{FilterableTableSource}} (FLINK-3849) interfaces. > The implementation can be based on Flink's {{TableInputFormat}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)