wenjin272 opened a new pull request, #811:
URL: https://github.com/apache/flink-agents/pull/811

   Linked issue: #780
   
   ### Purpose of change
   
   The quickstart `process_chat_response` sample caught every exception, logged 
it, and emitted no `OutputEvent`. A malformed LLM response then silently 
produced fewer outputs than inputs with no surface (DLQ event, error event, 
metric) for downstream operators to detect the missing record — a copy-paste 
anti-pattern for the recommended learning sample.
   
   - Replace `try/except: log()` with fail-fast in the Python quickstart agents 
(`review_analysis_agent`, `table_review_analysis_agent`, 
`product_suggestion_agent`); a parse error now propagates and fails the agent. 
Remove the unused `logging` imports.
   - Document production alternatives in the comment (raise to fail the input, 
emit an OutputEvent with an error sentinel, send a custom error event).
   - The Java samples already fail fast; align their comments with the Python 
ones so the intent is explicit.
   
   ### Tests
   
   Existing ut & e2e; quickstart examples run unchanged on valid responses and 
now fail loudly on malformed JSON.
   
   ### API
   
   no
   
   ### Documentation
   
   - [ ] `doc-needed`
   - [ ] `doc-not-needed`
   - [x] `doc-included`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to