spuru9 commented on code in PR #28373:
URL: https://github.com/apache/flink/pull/28373#discussion_r3388789078
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java:
##########
@@ -300,4 +300,12 @@ public class ForStOptions {
+ " Only valid when '"
+ EXECUTOR_WRITE_IO_INLINE.key()
+ "' is false.");
+
+ @Documentation.Section(Documentation.Sections.EXPERT_FORST)
+ public static final ConfigOption<Integer> CHECKPOINT_TRANSFER_THREAD_NUM =
Review Comment:
Can you check for the instruction for generated file to refer to these
option.
https://github.com/apache/flink/blob/master/flink-docs/README.md#configuration-documentation
##########
flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/snapshot/ForStIncrementalSnapshotStrategyTest.java:
##########
@@ -199,7 +199,7 @@ private ForStIncrementalSnapshotStrategy<?>
createSnapshotStrategy()
CompositeKeySerializationUtils.computeRequiredBytesInKeyGroupPrefix(2),
UUID.randomUUID(),
new TreeMap<>(),
- new
ForStStateDataTransfer(ForStStateDataTransfer.DEFAULT_THREAD_NUM),
+ new ForStStateDataTransfer(4),
Review Comment:
Would be better to derive the default values.
```suggestion
new
ForStStateDataTransfer(ForStOptions.CHECKPOINT_TRANSFER_THREAD_NUM.defaultValue()),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
