weiqingy commented on code in PR #831:
URL: https://github.com/apache/flink-agents/pull/831#discussion_r3393175665
##########
python/flink_agents/integrations/embedding_models/local/tests/test_ollama_embedding_model.py:
##########
@@ -34,14 +31,8 @@
pytestmark = pytest.mark.integration
test_model = os.environ.get("OLLAMA_EMBEDDING_MODEL", "all-minilm:22m")
-current_dir = Path(__file__).parent
try:
- # only auto setup ollama in ci with python 3.10 to reduce ci cost.
- if "3.10" in sys.version:
- subprocess.run(
- ["bash", f"{current_dir}/start_ollama_server.sh"], timeout=300,
check=True
- )
Review Comment:
Done here too — same `pull_model(test_model)` switch as the chat test.
3b8d9e1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]