weiqingy commented on PR #828: URL: https://github.com/apache/flink-agents/pull/828#issuecomment-4677255703
> LGTM. One thing to note: this fixes assume the job is restarted from a clean state. Thanks for the review @joeyutong . Agreed — that's the right way to read it. The change makes the context written to memory primitive-only from here on, and the read path now expects that primitive layout, so it doesn't migrate state already checkpointed by the old code: a savepoint taken before this fix still holds the non-primitive form and would hit the original problem on restore. So it's forward-looking — correct for fresh runs and for checkpoints written after it lands, not for restoring a pre-fix checkpoint. That fits where the project is today (no state-migration guarantees on the built-in tool context yet); if we ever need pre-fix-checkpoint compatibility we can add a migration shim on the read path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
