weiqingy commented on code in PR #835:
URL: https://github.com/apache/flink-agents/pull/835#discussion_r3394050365
##########
python/flink_agents/plan/agent_plan.py:
##########
@@ -280,6 +294,8 @@ def _get_actions(agent: Agent) -> List[Action]:
if marker is None:
continue
inner, listen_events, target = marker
+ if target is None:
+ _warn_if_action_returns_value(name, inner)
Review Comment:
The warning fires for `@action`-decorated methods here, but actions
registered imperatively via `add_action(name, events, func)` flow through the
`agent.actions` loop below (around line 311) and skip this check — so a plain
Python callable with `-> str` passed to `add_action` hits the same
silent-discard trap with no warning. Issue #834 scopes this to decorated
methods, so this may be deliberate — is covering the `add_action` path worth a
follow-up, or intentionally out of scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
