Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3206#discussion_r97768800
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -138,4 +141,30 @@ public void doubleStarPattern() {
assertFalse(matcher.filterPath(new Path("a/b")));
assertFalse(matcher.filterPath(new Path("a/b/c")));
}
+
+ @Test(expected = NullPointerException.class)
+ public void testIncluePatternIsNull() {
+ new GlobFilePathFilter(
+ null,
+ Collections.<String>emptyList());
+ }
+
+ @Test(expected = NullPointerException.class)
+ public void testExcludePatternIsNull() {
+ new GlobFilePathFilter(
+ Collections.singletonList("**"),
+ null);
+ }
+
+ @Test
+ public void testGlobFilterSerializable() throws IOException {
--- End diff --
How about using `CommonTestUtils.createCopySerializable()` here? That you
can validate also that the serialized copy behaves valid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
