Ryan-Nightwish commented on PR #830:
URL: https://github.com/apache/flink-agents/pull/830#issuecomment-4687922251
Hi @GreatEugenius @weiqingy @wenjin272, thanks again for your review. PR is
updated based on your comments, most of the feedback has been addressed. A few
notes on the non-trivial changes:
- Aspect correlation fix: I now pre-build all three `ChatRequestEvent`s
before dispatching, record a `{request_id → aspect}` map at that point, and
look up the dispatched aspect via `ChatResponseEvent.request_id` in the
response handler — so the mapping is fully under our control regardless of what
the model returns.
- Helper functions: Simple plumbing helpers are inlined into the action
methods. More meaningful helpers are kept as named module-level / private
static functions, with the doc linking to the full source file for their
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
