[
https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837684#comment-15837684
]
ASF GitHub Bot commented on FLINK-4905:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
I this case, the exception would not be logged, true.
It is a very rare corner case that should not affect correctness, and not
really distinguishable from the case where an exception is thrown after the
source went into finishing mode.
My feeling is to not log here.
- The advantage is that we don't pollute the log with meaningless
exception in the common case (many users would be led onto a false track).
- Given that the corner case you described does not affect any expected
behavior (the committing action might as well not have happened at all it it
were started a few msecs later) it is okay to "swallow" the exception.
- If it does in fact affect the offset committing in more cases, it will
surely also occur at another committing attempt during execution.
> Kafka test instability IllegalStateException: Client is not started
> -------------------------------------------------------------------
>
> Key: FLINK-4905
> URL: https://issues.apache.org/jira/browse/FLINK-4905
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Reporter: Robert Metzger
> Assignee: Andrew Efimov
> Labels: test-stability
> Attachments: Kafka08Fetcher.png
>
>
> The following travis build
> (https://s3.amazonaws.com/archive.travis-ci.org/jobs/170365439/log.txt)
> failed because of this error
> {code}
> 08:17:11,239 INFO org.apache.flink.runtime.jobmanager.JobManager
> - Status of job 33ebdc0e7c91be186d80658ce3d17069 (Read some records to
> commit offsets to Kafka) changed to FAILING.
> java.lang.RuntimeException: Error while confirming checkpoint
> at org.apache.flink.runtime.taskmanager.Task$4.run(Task.java:1040)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalStateException: Client is not started
> at
> org.apache.flink.shaded.com.google.common.base.Preconditions.checkState(Preconditions.java:173)
> at
> org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> at
> org.apache.curator.utils.EnsurePath$InitialHelper$1.call(EnsurePath.java:148)
> at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:107)
> at
> org.apache.curator.utils.EnsurePath$InitialHelper.ensure(EnsurePath.java:141)
> at org.apache.curator.utils.EnsurePath.ensure(EnsurePath.java:99)
> at
> org.apache.flink.streaming.connectors.kafka.internals.ZookeeperOffsetHandler.setOffsetInZooKeeper(ZookeeperOffsetHandler.java:133)
> at
> org.apache.flink.streaming.connectors.kafka.internals.ZookeeperOffsetHandler.prepareAndCommitOffsets(ZookeeperOffsetHandler.java:93)
> at
> org.apache.flink.streaming.connectors.kafka.internals.Kafka08Fetcher.commitInternalOffsetsToKafka(Kafka08Fetcher.java:341)
> at
> org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumerBase.notifyCheckpointComplete(FlinkKafkaConsumerBase.java:421)
> at
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.notifyOfCompletedCheckpoint(AbstractUdfStreamOperator.java:229)
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.notifyCheckpointComplete(StreamTask.java:571)
> at org.apache.flink.runtime.taskmanager.Task$4.run(Task.java:1035)
> ... 5 more
> 08:17:11,241 INFO org.apache.flink.runtime.taskmanager.Task
> - Attempting to cancel task Source: Custom Source -> Map -> Map -> Sink:
> Unnamed (1/3)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
