[ 
https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837833#comment-15837833
 ] 

ASF GitHub Bot commented on FLINK-3318:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2361#discussion_r97789351
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/State.java ---
    @@ -43,7 +43,14 @@ public State(final String name, final StateType 
stateType) {
                this.name = name;
                this.stateType = stateType;
     
    -           stateTransitions = new ArrayList<StateTransition<T>>();
    +           stateTransitions = new ArrayList<>();
    +   }
    +
    +   public State(String name, StateType stateType, 
Collection<StateTransition<T>> stateTransitions) {
    --- End diff --
    
    I agree with @chermenin and this class can be reverted to its previous 
state. In general, PRs should have the smallest diff possible in order to be 
easier to review.


> Add support for quantifiers to CEP's pattern API
> ------------------------------------------------
>
>                 Key: FLINK-3318
>                 URL: https://issues.apache.org/jira/browse/FLINK-3318
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> It would be a good addition to extend the pattern API to support quantifiers 
> known from regular expressions (e.g. Kleene star, ?, +, or count bounds). 
> This would considerably enrich the set of supported patterns.
> Implementing the count bounds could be done by unrolling the pattern state. 
> In order to support the Kleene star operator, the {{NFACompiler}} has to be 
> extended to insert epsilon-transition between a Kleene start state and the 
> succeeding pattern state. In order to support {{?}}, one could insert two 
> paths from the preceding state, one which accepts the event and another which 
> directly goes into the next pattern state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to