[
https://issues.apache.org/jira/browse/FLINK-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837891#comment-15837891
]
ASF GitHub Bot commented on FLINK-5628:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3215#discussion_r97799769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java
---
@@ -105,10 +110,12 @@ public ArchivedExecutionGraph(
this.serializedUserAccumulators = serializedUserAccumulators;
this.archivedExecutionConfig = executionConfig;
this.isStoppable = isStoppable;
- this.tracker = tracker;
+ this.jobSnapshottingSettings =
checkNotNull(jobSnapshottingSettings);
+ this.checkpointStatsSnapshot =
checkNotNull(checkpointStatsSnapshot);
--- End diff --
so these are not null even when checkpointing is disabled?
> CheckpointStatsTracker implements Serializable but isn't
> --------------------------------------------------------
>
> Key: FLINK-5628
> URL: https://issues.apache.org/jira/browse/FLINK-5628
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Ufuk Celebi
> Priority: Blocker
> Fix For: 1.3.0
>
>
> The CheckpointStatsTracker implements the Serializable interface, even though
> it no longer is serializable as it contains a List<ExecutionJobVertex>.
> This was introduced in 579bc96446d598a2cfe8237b4ebd62d8c9df3483 which
> reworked the checkpoint stats tracking,
> This does not affect 1.2 or 1.3 in any way (since these objects aren't
> serialized there), but it blocks the implementation of the HistoryServer.
> The AccessExecution*/ArchivedExecution* classes, which are supposed to be a
> serializable form of the ExecutionGraph, are thus broken as they also make
> use of the CheckpointStatsTracker.
> (Note: * = Graph/ExecutionJobVertex/ExecutionVertex/Execution) .
> This wasn't catched in tests since no ExecutionJobVertices were given to the
> CheckpointStatsTracker in ArchivedExecutionGraphTest#setExecutionGraph.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
