Dennis-Mircea commented on code in PR #1085:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1085#discussion_r3443566292
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -469,6 +475,11 @@ private boolean checkIfBlockedAndTriggerScalingEvent(
Instant now) {
var scaleEnabled = conf.get(SCALING_ENABLED);
var isExcluded = CalendarUtils.inExcludedPeriods(conf, now);
+ if (scaleEnabled && !isExcluded) {
+ // Not blocked. The scaling report is emitted later, once the
decision is final
+ // (after memory tuning, the max-resource check, and the custom
scaling executors).
+ return false;
Review Comment:
Returning false let us proceed further and not act as "blocked", so memory
tuning and scaling executors can be applied further +
`autoScalerEventHandler.handleScalingEvent`. By returning true here it means
that we are "blocked" and scaling execution is aborted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
