wilmerdooley commented on PR #28486: URL: https://github.com/apache/flink/pull/28486#issuecomment-4753905495
I have run spotless:apply and pushed it, so the format check should be sorted. On FLINK-23767 (#16817, FLIP-180): it removed this line on purpose. FLIP-180 makes idleness user-controlled and drops the code that auto-marks a source idle, to avoid late records, so re-adding it reintroduces exactly the automatic idleness it set out to remove. I agree it should not go back as a blind revert. That said, the empty/all-unregistered case still looks like a real gap (FLINK-38454 deliberately left this branch alone). FLIP-180 and FLINK-38454 both handle "inputs gone" by flushing the maximum watermark rather than signalling idle, so emitting the combined max watermark when the outputs drain to empty would fit the current model better than toggling the idle flag. Would you prefer that direction, or to handle it closer to StatusWatermarkValve / the idleness path? Happy to follow your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
