snuyanzin commented on code in PR #28489:
URL: https://github.com/apache/flink/pull/28489#discussion_r3445772149
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/restore/RocksDBHandle.java:
##########
@@ -306,7 +313,13 @@ public DBOptions getDbOptions() {
@Override
public void close() throws Exception {
IOUtils.closeQuietly(defaultColumnFamilyHandle);
- IOUtils.closeQuietly(nativeMetricMonitor);
+ if (nativeMetricMonitor != null) {
+ // Monitor owns the statistics wrapper.
+ IOUtils.closeQuietly(nativeMetricMonitor);
+ } else {
Review Comment:
will it be an issue (double closing), asking since `quiteClose` should catch
all the exceptions?
Or we should keep unclosed in some cases?
anyway it is just a nit pick, so feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
