[ 
https://issues.apache.org/jira/browse/FLINK-39955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090405#comment-18090405
 ] 

krooswu commented on FLINK-39955:
---------------------------------

Hi @ Fabian Hueske, this is a very clear and meaningful issue. I'd love to take 
this task and fix the time indicator handling in SystemTypeInference. Could you 
please assign it to me? Thanks!

> PTF OutputTypeStrategy can emit time indicator types
> ----------------------------------------------------
>
>                 Key: FLINK-39955
>                 URL: https://issues.apache.org/jira/browse/FLINK-39955
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Fabian Hueske
>            Priority: Major
>
> An OutputTypeStrategy that simply emits the type information of an input 
> table emits time indicator types if the input table has a time attribute.
> However, PTFs should only emit time attributes if the `on_time` argument is 
> specified and all of this should be managed by the framework.
> There's different ways to go about this:
>  # the framework (via SystemTypeInference) throws if the PTF output type 
> inference returns a time indicator
>  # the framework (via SystemTypeInference) converts the time indicator type 
> into a regular timestamp type before it is handed to the input and output 
> type strategies
>  # the framework (via SystemTypeInference) converts any time indicators 
> returned by an output type strategy automatically into a timestamp type.
> IMO, a combination of 1. and 2. is the best approach. It prevents that users 
> accidentally return a time indicator type (because none are passed in) and 
> fails if the user manually creates one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to