Efrat19 commented on code in PR #28369:
URL: https://github.com/apache/flink/pull/28369#discussion_r3448661986
##########
flink-end-to-end-tests/test-scripts/common_s3_seaweedfs.sh:
##########
@@ -107,12 +108,17 @@ function s3_setup_with_provider {
add_optional_plugin "s3-fs-$1"
# reads (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY)
set_config_key "$2"
"com.amazonaws.auth.EnvironmentVariableCredentialsProvider"
- # change endpoint to minio's location
+ # change endpoint to seaweedfs's location
set_config_key "s3.endpoint" "$S3_ENDPOINT"
- # If the test is using virtual host style (default), then it tries to reach
minio on <bucket>.localhost:<port>,
+ # If the test is using virtual host style (default), then it tries to reach
seaweedfs on <bucket>.localhost:<port>,
# which docker does not properly forward.
set_config_key "s3.path.style.access" "true"
set_config_key "s3.path-style-access" "true"
}
source "$(dirname "$0")"/common_s3_operations.sh
+
+# SeaweedFS does not expose on-disk directories as S3 buckets,
+# so the bucket must be created explicitly
+aws_cli s3 mb "s3://$IT_CASE_S3_BUCKET"
+aws_cli s3 cp "/hostdir/test-data/words" "$S3_TEST_DATA_WORDS_URI"
Review Comment:
I added a healthcheck to `s3_start`, it is more reliable and IMO easier to RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
