[ 
https://issues.apache.org/jira/browse/FLINK-39374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090611#comment-18090611
 ] 

Qiu Yanjun commented on FLINK-39374:
------------------------------------

Hi Flink maintainers, I opened a PR for this issue: 
https://github.com/apache/flink-connector-kudu/pull/22. It includes a focused 
regression test and fix. Could you please review when you have a chance? Thanks.

> Rename KuduWriterConfig.maxBufferSize to maxMutationBufferOps
> -------------------------------------------------------------
>
>                 Key: FLINK-39374
>                 URL: https://issues.apache.org/jira/browse/FLINK-39374
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kudu
>            Reporter: Marton Greber
>            Priority: Minor
>              Labels: pull-request-available
>
> KuduWriterConfig.Builder exposes a field named maxBufferSize, but it maps to 
> KuduSession.setMutationBufferSpace() — a count of buffered mutation 
> operations, not a byte size. The name maxBufferSize implies a byte quantity.
> The field, its getter/setter, and the corresponding CLI option 
> (sink.max-buffer-size) should be renamed to reflect the actual semantics 
> (e.g. maxMutationBufferOps / sink.max-mutation-buffer-ops).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to