snuyanzin commented on code in PR #28497:
URL: https://github.com/apache/flink/pull/28497#discussion_r3454289962
##########
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTest.java:
##########
@@ -339,13 +339,13 @@ public void testReaderSnapshotRestore() throws Exception {
// compare if the results contain what they should contain and also if
// they are the same, as they should.
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit1)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit2)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit3)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit4)));
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit1))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit2))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit3))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit4))).isTrue();
Review Comment:
assert has contains method, so no need for `isTrue`
##########
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTest.java:
##########
@@ -339,13 +339,13 @@ public void testReaderSnapshotRestore() throws Exception {
// compare if the results contain what they should contain and also if
// they are the same, as they should.
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit1)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit2)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit3)));
- Assert.assertTrue(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit4)));
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit1))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit2))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit3))).isTrue();
+ assertThat(initTestInstance.getOutput().contains(new
StreamRecord<>(fsSplit4))).isTrue();
- Assert.assertArrayEquals(
- initTestInstance.getOutput().toArray(),
restoredTestInstance.getOutput().toArray());
+ assertThat(restoredTestInstance.getOutput().toArray())
Review Comment:
what is the reason to convert to array here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
