argoyal2212 commented on code in PR #28500:
URL: https://github.com/apache/flink/pull/28500#discussion_r3456146380
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamTableEnvironment.java:
##########
@@ -88,7 +88,13 @@ public interface StreamTableEnvironment extends
TableEnvironment {
* TableEnvironment}.
*/
static StreamTableEnvironment create(StreamExecutionEnvironment
executionEnvironment) {
- return create(executionEnvironment,
EnvironmentSettings.newInstance().build());
+ return create(
+ executionEnvironment,
+ EnvironmentSettings.newInstance()
+ .withConfiguration(
+ (org.apache.flink.configuration.Configuration)
Review Comment:
Dropped the ReadableConfig -> Configuration cast. create(env) now builds
EnvironmentSettings via the builder and only switches to inBatchMode() when the
env RUNTIME_MODE is BATCH,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
