raminqaf commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3457802294
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableTestUtils.java:
##########
@@ -50,4 +57,26 @@ static ContinuousRefreshHandler getContinuousRefreshHandler(
return ContinuousRefreshHandlerSerializer.INSTANCE.deserialize(
resolvedTable.getSerializedRefreshHandler(), classLoader);
}
+
+ /**
+ * Runs an EXPLAIN statement through the gateway and asserts its full plan
equals the given
+ * golden resource. The per-test catalog name is normalized to {@code
$CATALOG} before
+ * comparison.
+ */
+ static void verifyExplainPlan(
Review Comment:
Good point. I wanted to do the verification in the IT cases of the Gateway.
Now, I removed the custom helper and moved plan-content verification into the
planner tests.
Gateway ITs no longer assert plan text. They only check that EXPLAIN returns
a single non-empty plan, succeeds, and is is side-effect-free.
Dropped `MaterializedTableTestUtils.verifyExplainPlan` and the gateway
golden files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
