GreatEugenius commented on code in PR #854: URL: https://github.com/apache/flink-agents/pull/854#discussion_r3465781012
########## api/src/main/java/org/apache/flink/agents/api/tools/ToolParameterSource.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.agents.api.tools; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonValue; + +/** Source for a framework-injected tool parameter. */ +public enum ToolParameterSource { + CONFIG("config"), + SENSORY_MEMORY("sensory_memory"), + SHORT_TERM_MEMORY("short_term_memory"); + + private final String value; + + ToolParameterSource(String value) { + this.value = value; + } + + @JsonValue + public String getValue() { + return value; + } + + @JsonCreator + public static ToolParameterSource fromValue(String value) { + if ("action_config".equals(value)) { Review Comment: Agreed. `action_config` was leftover naming from the earlier hook-based iteration and is misleading because it collides with the existing per-action config concept. I removed the `action_config` alias from both Java and Python. The public source names are now only the documented ones: `config`, `sensory_memory`, and `short_term_memory`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
