section9-lab commented on PR #718: URL: https://github.com/apache/flink-agents/pull/718#issuecomment-4787621054
Thanks @wenjin272 for the review.\n\nI have addressed item 1 in commit 212adaf by adding the Gemini chat model constants to ResourceName on both sides:\n\n- Java: ResourceName.ChatModel.GEMINI_CONNECTION and ResourceName.ChatModel.GEMINI_SETUP\n- Python Java mapping: ResourceName.ChatModel.Java.GEMINI_CONNECTION and ResourceName.ChatModel.Java.GEMINI_SETUP\n\nI also verified the ResourceName cross-language consistency check, the Python ResourceName test, and the api module compilation locally.\n\nFor item 2, I will handle the documentation as a follow-up. After this PR is merged, I will branch from the latest main and open a separate docs PR linked to #648 / as a follow-up to #718. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
