autophagy opened a new pull request, #28545:
URL: https://github.com/apache/flink/pull/28545

   ## What is the purpose of the change
   
   When testing examples for the ProcessTableFunctionTestHarness, it was found 
that since `withScalarArguments` autoboxes the the input value (for example 
`int` to `Integer`), it was incompatible with PTFs that have primitive scalar 
input arguments, since `int` is not assignable from `Integer`. This was just an 
error in the preflight check, and would have worked without it.
   
   This PR instead converts the expected primitive class to the wrapper class 
before checking assignability.
   
   ## Brief change log
   
   - *Fixed bug that prevented users from using PTFs with primitive scalar 
arguments with the PTF test harness*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added `testPrimitiveScalarArguments` in 
`ProcessTableFunctionTestHarnessTest.java`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to