davidradl commented on code in PR #28533:
URL: https://github.com/apache/flink/pull/28533#discussion_r3480022967
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala:
##########
@@ -329,9 +329,9 @@ object FlinkBatchRuleSets {
FlinkSemiAntiJoinFilterTransposeRule.INSTANCE,
// set operators
- ReplaceIntersectWithSemiJoinRule.INSTANCE,
+ CoreRules.INTERSECT_TO_SEMI_JOIN,
Review Comment:
My AI says
- Verify that the expanded join condition doesn't negatively impact query
performance in production workloads
- Confirm that ReplaceMinusWithAntiJoinRule removal (mentioned but not
shown) is equally safe
- Consider adding a comment in the rule sets explaining why the Calcite
rules are preferred over custom implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
