arvindKandpal-ksolves commented on PR #28218: URL: https://github.com/apache/flink/pull/28218#issuecomment-4807599938
Thanks for the review @snuyanzin! 1. **parallelism.default** — removed. All 5 tests pass without it. 2. **SQL vs Table API** — the fix covers both paths. SQL does not reproduce the bug because Calcite silently drops `ORDER BY` in a subquery without `LIMIT/FETCH` during SQL-to-rel conversion, so the collation is gone before the rule runs. The Table API preserves the `LogicalSort` through to physical planning where the crash occurs. As @weiqingy noted earlier: > "The SQL form → plans fine, no crash, with or without the fix. > Table-API query plans without the crash with the fix applied." 3. **System columns** — the bounds check `_.getFieldIndex < fieldCount` is column-type agnostic. It applies equally to regular columns, metadata columns, and rowtime attributes. No separate test needed. *Note: Research and investigation for this was assisted using Claude Sonnet 4.6.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
