leonardBang commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3482557200
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106,
hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter
hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107,
rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks,
5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1,
schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS`
VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
You are right. The `171798691841/842` values are not valid fixture IDs and
should not be accepted as an alternative rendering of the customer primary key.
That would make the assertion too loose and could hide a real data correctness
issue.
I updated the test to assert the actual fixture IDs for the current pipeline
e2e path, which uses the Oracle incremental snapshot source. The assertion now
only keeps the `BIGINT` / `DECIMAL(38, 0)` schema alternative, because that is
a schema type-rendering difference for Oracle `INT` / `NUMBER`, not a data
value difference. If we need to cover legacy source behavior separately, we
should add a source-specific assertion/test for that path instead of accepting
different ID values in this incremental snapshot test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
