snuyanzin commented on code in PR #28561:
URL: https://github.com/apache/flink/pull/28561#discussion_r3488250934
##########
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/input/MultiStateKeyIteratorTest.java:
##########
@@ -206,24 +206,20 @@ public void testIteratorSkipsEmptyDescriptors() throws
Exception {
keys.add(iterator.next());
}
- Assert.assertEquals("Unexpected number of keys", 2, keys.size());
- Assert.assertEquals("Unexpected keys found", Arrays.asList(1, 2),
keys);
+ assertThat(keys).isEqualTo(Arrays.asList(1, 2));
Review Comment:
we shouldn't drop such things silently without justification
I see lots of messages removed which are even don't match test name, any
justification for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
