Efrat19 commented on PR #267: URL: https://github.com/apache/flink-connector-kafka/pull/267#issuecomment-4829801563
> @Efrat19 let me know what you think of the last set of change. Thanks! Hey, thank you for addressing the [default behavior concern](https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3448100102) and the [APIs drift](https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3448114634). I think it looks better now. 1. Please update the PR description 2. I am still concerned about the chosen approach. I think the main gap here is that a different `auto.offset.reset` strategy should be used on startup vs recovery. Previously it was always inferred by `StartingOffsetInitializer`, (incorrect during recovery), and now it will always be read from user's `auto.offset.reset` (when provided), and will be wrong during startup so we are only shifting the problem somewhere else Do you think we can distinguish startup and recovery modes, and use `StartingOffsetInitializer. getAutoOffsetResetStrategy` for startup, and `none`/user provided `auto.offset.reset` during recovery? Or am I missing something and the solution isn't just about recovery? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
