vernedeng commented on code in PR #123:
URL:
https://github.com/apache/flink-connector-pulsar/pull/123#discussion_r3490156683
##########
pom.xml:
##########
@@ -51,23 +51,19 @@ under the License.
</modules>
<properties>
- <flink.version>1.20.3</flink.version>
+ <flink.version>2.2.1</flink.version>
<pulsar.version>3.0.5</pulsar.version>
<scala.binary.version>2.12</scala.binary.version>
<bouncycastle.version>1.69</bouncycastle.version>
- <scala-reflect.version>2.12.7</scala-reflect.version>
- <scala-library.version>2.12.7</scala-library.version>
-
<jsr305.version>1.3.9</jsr305.version>
<junit5.version>5.9.1</junit5.version>
<assertj.version>3.23.1</assertj.version>
<mockito.version>4.11.0</mockito.version>
<archunit.version>1.0.1</archunit.version>
<testcontainers.version>1.21.4</testcontainers.version>
- <japicmp.skip>false</japicmp.skip>
- <japicmp.referenceVersion>3.0.0-1.16</japicmp.referenceVersion>
+ <japicmp.skip>true</japicmp.skip>
Review Comment:
Flink 2.x is a major bump and Sink/Source APIs are source-incompatible. The
binary-compatibility check would be all-red and is meaningless here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
