Dennis-Mircea commented on code in PR #1088:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1088#discussion_r3491910243
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -375,17 +376,65 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Quota of the CPU count. When scaling would go
beyond this number the the scaling is not going to happen.");
- public static final
ConfigOption<JobVertexScaler.KeyGroupOrPartitionsAdjustMode>
+ @Deprecated
+ public static final ConfigOption<KeyGroupOrPartitionsAdjustMode>
SCALING_KEY_GROUP_PARTITIONS_ADJUST_MODE =
autoScalerConfig("scaling.key-group.partitions.adjust.mode")
-
.enumType(JobVertexScaler.KeyGroupOrPartitionsAdjustMode.class)
- .defaultValue(
-
JobVertexScaler.KeyGroupOrPartitionsAdjustMode.EVENLY_SPREAD)
+ .enumType(KeyGroupOrPartitionsAdjustMode.class)
+
.defaultValue(KeyGroupOrPartitionsAdjustMode.EVENLY_SPREAD)
.withFallbackKeys(
oldOperatorConfigKey(
"scaling.key-group.partitions.adjust.mode"))
.withDescription(
- "How to adjust the parallelism of Source
vertex or upstream shuffle is keyBy");
+ "Deprecated, use scaling.alignment.mode
instead. How to adjust "
+ + "the parallelism of Source
vertex or upstream partitioning is keyBy");
+
+ public static final ConfigOption<String> ALIGNMENT_MODE =
+ autoScalerConfig("scaling.alignment.mode")
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
